Propagate route harvest cancellation#2423
Open
MrAlias wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
==========================================
- Coverage 69.11% 69.01% -0.10%
==========================================
Files 332 332
Lines 44197 44252 +55
==========================================
- Hits 30546 30542 -4
- Misses 11775 11817 +42
- Partials 1876 1893 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mariomac
reviewed
Jun 18, 2026
mariomac
left a comment
mariomac
left a comment
Contributor
There was a problem hiding this comment.
Pretty good!!! I just have few cosmetic suggestions.
MrAlias
added
bug
Pass harvest contexts through Java
MrAlias
force-pushed
the
codex/2034-route-harvester-integration
branch
from
e59de9d to
3354810
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This completes the route-harvester integration step for #2034 after the internal JVM attach path gained context support. Previously, the harvester could return on timeout while the Java extraction worker continued blocked in the background. Passing the timeout context through attach and output reading gives the worker a cancellation path instead of accumulating retained workers across repeated timeouts.
Fixes #2034.
Validation
make generatego test ./pkg/internal/transform/route/harvestgo test ./pkg/internal/jvmtools/...GOOS=darwin go test -c -o /tmp/harvest-darwin.test ./pkg/internal/transform/route/harvestgo test ./pkg/internal/transform/route/...